Conversation
Following resolution in ReadiumCSS, pageGutter only applies in pagination, scrollLeft and scrollRight in scroll. LineLength helper has to take padding directly since scroll can have different values, unlike pageGutter.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following resolution in ReadiumCSS,
pageGutteronly applies in pagination,scrollPaddingLeftandscrollPaddingRightin scroll. LineLength helper now has to take padding directly since scroll can have different values, unlikepageGutter.Since Fonts are no longer distributed through ReadiumCSS, the build has also been simplified as we do not need to copy these fonts in Navigator’s package any longer.
Will be in draft until Readium CSS version
2.0.0(stable) is released so that we do not have to do a subsequent update.