Skip to content

Conversation

@alizard0
Copy link
Member

@alizard0 alizard0 commented Dec 12, 2025

  1. Implemented abstract openssf metric provider, its implementations are added to a list in runtime.
  2. Implemented OpenSSF Client (with only one GET request)
  3. Implemented tests
  4. Review the thresholds
  5. Perform end-to-end tests (using frontend)
Screenshot 2025-12-22 at 11 31 10

@rhdh-gh-app
Copy link

rhdh-gh-app bot commented Dec 12, 2025

Important

This PR includes changes that affect public-facing API. Please ensure you are adding/updating documentation for new features or behavior.

Missing Changesets

The following package(s) are changed by this PR but do not have a changeset:

  • @red-hat-developer-hub/backstage-plugin-scorecard-backend

See CONTRIBUTING.md for more information about how to add changesets.

Changed Packages

Package Name Package Path Changeset Bump Current Version
backend workspaces/scorecard/packages/backend none v0.0.0
@red-hat-developer-hub/backstage-plugin-scorecard-backend-module-openssf workspaces/scorecard/plugins/scorecard-backend-module-openssf minor v0.0.0
@red-hat-developer-hub/backstage-plugin-scorecard-backend workspaces/scorecard/plugins/scorecard-backend none v2.2.0

Copy link
Member

@JessicaJHee JessicaJHee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great so far and works! Left a suggestion here, PTAL!

@dzemanov
Copy link
Member

Thank you for the PR!

I have only a couple of questions:

  1. Default thresholds for numbers are set to following values: <10 success, 10-50 warning, >50 error. Do these thresholds need to be adjusted for openssf metrics, I see the resulting score should be out of 10, -1 is error?
  2. Does it make sense to allow admins to configure in app-config different custom thresholds for openssf metrics, or the same score should be always mapped to the same threshold result (success, warning, error)?

@alizard0 alizard0 changed the title [DRAFT] Add OpenSSF Scorecard Add OpenSSF Scorecard Dec 22, 2025
@alizard0 alizard0 changed the title Add OpenSSF Scorecard feat(scorecard): add OpenSSF scorecard Dec 22, 2025
@alizard0
Copy link
Member Author

/retest

@alizard0 alizard0 force-pushed the add-scorecard-backend-module-openssf branch from cec553f to 4eb490d Compare December 22, 2025 16:08
@alizard0
Copy link
Member Author

/retest

@alizard0
Copy link
Member Author

Quality Gate Failed Quality Gate failed

Failed conditions 11.1% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

I dont agree tbh, the code isn't duplicated. This complains about a list with objects that contains data, the only "duplicated" code is the name of each variable of such objects.

@alizard0
Copy link
Member Author

/retest

…ed unit tests; Added documentation; Review work
Copy link
Member

@dzemanov dzemanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @alizard0, works great!

Screenshot 2025-12-23 at 16 20 10

@dzemanov
Copy link
Member

You will just need to fix prettier:
yarn prettier:fix

@alizard0
Copy link
Member Author

/retest

@christoph-jerolimov
Copy link
Member

/override "SonarCloud Code Analysis"

@openshift-ci
Copy link

openshift-ci bot commented Jan 5, 2026

@christoph-jerolimov: Overrode contexts on behalf of christoph-jerolimov: SonarCloud Code Analysis

Details

In response to this:

/override "SonarCloud Code Analysis"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@alizard0 alizard0 force-pushed the add-scorecard-backend-module-openssf branch from 569d252 to 30a5e3b Compare January 5, 2026 16:15
@alizard0 alizard0 force-pushed the add-scorecard-backend-module-openssf branch from 30a5e3b to fa3404c Compare January 7, 2026 08:58
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jan 7, 2026

Quality Gate Failed Quality Gate failed

Failed conditions
11.1% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

@christoph-jerolimov christoph-jerolimov merged commit 562dcc6 into redhat-developer:main Jan 7, 2026
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants