-
Notifications
You must be signed in to change notification settings - Fork 85
feat(scorecard): add OpenSSF scorecard #1952
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(scorecard): add OpenSSF scorecard #1952
Conversation
|
Important This PR includes changes that affect public-facing API. Please ensure you are adding/updating documentation for new features or behavior. Missing ChangesetsThe following package(s) are changed by this PR but do not have a changeset:
See CONTRIBUTING.md for more information about how to add changesets. Changed Packages
|
JessicaJHee
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great so far and works! Left a suggestion here, PTAL!
workspaces/scorecard/plugins/scorecard-backend-module-openssf/src/module.ts
Outdated
Show resolved
Hide resolved
workspaces/scorecard/plugins/scorecard-backend-module-openssf/src/clients/OpenSSFClient.ts
Show resolved
Hide resolved
|
Thank you for the PR! I have only a couple of questions:
|
|
/retest |
…wed the OpenSSF thresholds
cec553f to
4eb490d
Compare
|
/retest |
I dont agree tbh, the code isn't duplicated. This complains about a list with objects that contains data, the only "duplicated" code is the name of each variable of such objects. |
|
/retest |
workspaces/scorecard/plugins/scorecard-backend-module-openssf/README.md
Outdated
Show resolved
Hide resolved
…ed unit tests; Added documentation; Review work
workspaces/scorecard/plugins/scorecard-backend-module-openssf/src/clients/OpenSSFClient.ts
Outdated
Show resolved
Hide resolved
Co-authored-by: Dominika Zemanovicova <[email protected]>
Co-authored-by: Dominika Zemanovicova <[email protected]>
dzemanov
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @alizard0, works great!
|
You will just need to fix prettier: |
|
/retest |
|
/override "SonarCloud Code Analysis" |
|
@christoph-jerolimov: Overrode contexts on behalf of christoph-jerolimov: SonarCloud Code Analysis DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
workspaces/scorecard/plugins/scorecard-backend-module-openssf/package.json
Outdated
Show resolved
Hide resolved
569d252 to
30a5e3b
Compare
30a5e3b to
fa3404c
Compare
|
562dcc6
into
redhat-developer:main


Uh oh!
There was an error while loading. Please reload this page.