refactor(output): unify OutputFormat and standardize table library#760
Merged
joshrotenberg merged 1 commit intomainfrom Mar 3, 2026
Merged
refactor(output): unify OutputFormat and standardize table library#760joshrotenberg merged 1 commit intomainfrom
joshrotenberg merged 1 commit intomainfrom
Conversation
) Phase 1 of output formatting cleanup: - Remove duplicate output::OutputFormat enum, re-export cli::OutputFormat - Drop comfy-table dependency, standardize on tabled with Style::blank() - Consolidate duplicated apply_jmespath/handle_output/print_formatted_output into output.rs, re-export from cloud/utils.rs and enterprise/utils.rs - Standardize Auto mode: Table when TTY, Json when piped - Remove manual OutputFormat conversion boilerplate across commands
This was referenced Mar 3, 2026
joshrotenberg
added a commit
that referenced
this pull request
Mar 3, 2026
…761) Add #[derive(Tabled)] row structs to all Enterprise list and get commands, replacing the generic print_as_table() which dumped all JSON fields uncurated. This matches the Cloud command patterns established in PR #760. Row structs added: DatabaseRow, NodeRow, UserRow, RoleRow, AclRow, ModuleRow, ShardRow, ProxyRow. Get commands use DetailRow for vertical key-value display. Cluster get also uses DetailRow. Output branching uses resolve_auto() (now public) to render curated tables on TTY and pass through JSON/YAML for piped output. JMESPath queries are applied before table rendering.
joshrotenberg
added a commit
that referenced
this pull request
Mar 3, 2026
…761) (#763) Add #[derive(Tabled)] row structs to all Enterprise list and get commands, replacing the generic print_as_table() which dumped all JSON fields uncurated. This matches the Cloud command patterns established in PR #760. Row structs added: DatabaseRow, NodeRow, UserRow, RoleRow, AclRow, ModuleRow, ShardRow, ProxyRow. Get commands use DetailRow for vertical key-value display. Cluster get also uses DetailRow. Output branching uses resolve_auto() (now public) to render curated tables on TTY and pass through JSON/YAML for piped output. JMESPath queries are applied before table rendering.
joshrotenberg
added a commit
that referenced
this pull request
Mar 3, 2026
) * feat(enterprise): add curated table formatters for list/get commands (#761) Add #[derive(Tabled)] row structs to all Enterprise list and get commands, replacing the generic print_as_table() which dumped all JSON fields uncurated. This matches the Cloud command patterns established in PR #760. Row structs added: DatabaseRow, NodeRow, UserRow, RoleRow, AclRow, ModuleRow, ShardRow, ProxyRow. Get commands use DetailRow for vertical key-value display. Cluster get also uses DetailRow. Output branching uses resolve_auto() (now public) to render curated tables on TTY and pass through JSON/YAML for piped output. JMESPath queries are applied before table rendering. * fix(output): standardize table styles and add Cloud ACL formatters Polishes output formatting consistency across the codebase: - Replace all Style::rounded()/Style::modern() with Style::blank() - Add curated table formatters for Cloud ACL commands (rules, roles, users) - Use output_with_pager where println! was used for table output - Re-export resolve_auto from cloud utils for format branching
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Phase 1 of #749 (output formatting cleanup):
output::OutputFormatenum, re-exportcli::OutputFormatas the single source of truthcomfy-tabledependency, standardize ontabledwithStyle::blank()apply_jmespath/handle_output/print_formatted_outputintooutput.rs, re-export fromcloud/utils.rsandenterprise/utils.rsAutomode: table when TTY, JSON when pipedOutputFormatconversion boilerplate across commandsNet result: -148 lines, one fewer dependency, single code path for output formatting.
Closes #749
Test plan
cargo clippy --all-targets --all-features -- -D warningspassescargo test --lib --all-featurespasses (89 tests)-o json,-o yaml,-o tablework for Cloud and Enterprise commands