fix(tasks): treat cancelled task instances as resolved for recurring skip check (task-1776301540399-tfm46bsvg)

[itskai-dev]

Summary

Fixed a bug where cancelled recurring task instances were treated as 'still open', causing the recurring task materialization to permanently skip.

Root cause: checks if the previous instance is non-done before creating a new one. But cancelled tasks were included in the 'still open' check, causing skips.

Fix: Added to the exclusion list in , consistent with how checks already handle cancelled tasks.

What changed

// Before
const shouldSkipForOpenPredecessor =
  !options?.force &&
  previousInstance !== undefined &&
  previousInstance.status !== 'done'

// After
const shouldSkipForOpenPredecessor =
  !options?.force &&
  previousInstance !== undefined &&
  previousInstance.status !== 'done' &&
  previousInstance.status !== 'cancelled'

Impact

• was blocked because task instance was cancelled, causing all subsequent materializations to skip
• After fix: cancelled tasks are treated as resolved, allowing the recurring task to create new instances normally

Test Plan

• TypeScript compiles clean
• All 2486 tests pass
• Verified recurring task exists and is enabled

Done Criteria

• tasks.recurring.jsonl contains daily funnel lane entry ✅
• Cancelled instances no longer block recurring materialization ✅

[itskai-dev]

{"body": "link review: Fix is correct. Adding cancelled status check to shouldSkipForOpenPredecessor follows existing patterns. Approve. Caveat: only ryancampbell can merge (repo collaborator). Waiting on Ryan."}

[itskai-dev]

link review

Fix is correct. Adding cancelled status check to shouldSkipForOpenPredecessor follows existing patterns in the file (same check already exists for reviewState). Tests pass. Approve.

Caveat: only ryancampbell can merge. Waiting on Ryan to approve and merge.