fix: getNextTask skip board_truth/parked_pass + sweeper pr_merged guards#1338
Open
itskai-dev wants to merge 14 commits into
Open
fix: getNextTask skip board_truth/parked_pass + sweeper pr_merged guards#1338itskai-dev wants to merge 14 commits into
itskai-dev wants to merge 14 commits into
Conversation
…tch cloud (task-1774294960543-v778wwmio)
- Add POST /tracking/live-cta and POST /tracking/live-visit endpoints to docs - Remove stale /activation/ghost-signups and /activation/ghost-signup-nudge from docs Fixes route-docs contract check failure blocking PR #1153
…ion requeue Two paths were incorrectly requeuing PR-merged tasks to todo: 1. Artifact-rejection (line ~362): missing qa_bundle after 24h in validating → now closes to done if pr_merged, only requeues if not merged 2. Drift-repair dupeErr block (line ~428): approved but dupeErr blocks close → PR merge is canonical, so pr_merged + approved → close to done Canonical rule: PR merge = task completion signal, not artifact completeness. qa_bundle artifacts are evidence of work, not completion criteria. Refs: task-1778298996028-ah73bdq3m
getNextTask() was surfacing closed/stale tasks because it had no awareness of: - review_state=parked_pass/fail (QA-complete tasks) - board_truth metadata (explicit per-task lane routing) - blocked_external flags - reopen=true (tasks being actively reworked) These filters were already missing when the sweeper fix (PR #2769) closed the bounce path — tasks that landed back in todo kept getting picked up by the next-task selector. Combined with PR #2769, this fully addresses the structural routing bug reported by link (M cut bounced 13+ times). Ref: task-1778408493344-cgd00jx71
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two-part routing fix for the structural bug causing closed tasks to bounce back via
/tasks/next:Part 1 — sweeper bounce path
executionSweeper.tswas requeuing PR-merged tasks totodowhen missing artifacts. Twopr_mergedguards added:donedonePart 2 — getNextTask selector
getNextTask()had no awareness of board truth signals. Added four filters:Why Both Parts
Part 1 stops the sweeper from putting PR-merged tasks back in
todo.Part 2 stops
getNextTaskfrom surfacing tasks that carry board-truth signals.Together: closed tasks stay closed, parked tasks stay parked, board-truth-routed tasks go to the right lane.
Testing
task-1777172195778-9zofmfuya(parked_pass) — correctly filteredtask-1777356670701-lo4e5fiim(board_truth → link, blocked_external) — correctly filtered/tasks/nextpull proof on production nodeReported by link: M cut bounced 13+ times. Root cause was both paths combined.
Ref: task-1778408493344-cgd00jx71