fix: routing bug — getNextTask + sweeper bounce paths (M cut 13x bounce)#1339
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two-part routing fix for the structural bug causing closed tasks to bounce back via
/tasks/next:Part 1 — sweeper bounce path
executionSweeper.tswas requeuing PR-merged tasks totodowhen missing artifacts. Twopr_mergedguards added:donedonePart 2 — getNextTask selector
getNextTask()had no awareness of board truth signals. Added four filters:Why Both Parts
Part 1 stops the sweeper from putting PR-merged tasks back in
todo.Part 2 stops
getNextTaskfrom surfacing tasks that carry board-truth signals.Together: closed tasks stay closed, parked tasks stay parked, board-truth-routed tasks go to the right lane.
Testing
task-1777172195778-9zofmfuya(parked_pass) — correctly filteredtask-1777356670701-lo4e5fiim(board_truth → link, blocked_external) — correctly filteredReported by link: M cut bounced 13+ times. Root cause was both paths combined.
Ref: task-1778408493344-cgd00jx71