fix(room): align /room/participants auth with cloud/browser path#1341
Merged
Conversation
…cipants Per ROOM_MODEL_V0, /room/participants is a room output the cloud/browser path reads using the host credential. Requiring REFLECTT_HOST_HEARTBEAT_TOKEN locks those callers out. Mirrors manage.ts:checkManageAuth's allowHostCredential option — heartbeat token still works, host credential is now a second valid secret on this one route only. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
GET /room/participantsto authenticate with a scoped bearer token for the cloud/browser pathroom-routesValidation
npm run buildtsc --noEmitvitest runonroom-presence-store,room-event-bridge,artifact-store-roomWhy
reflectt-node#1340narrowing was blocked because the ROOM_MODEL contract expects/room/participantsto be readable through the normal cloud/browser path, while node only acceptedREFLECTT_HOST_HEARTBEAT_TOKEN.