fix(universes): Update PATCH request body to include gameJoinRestriction#8
Merged
marinofranz merged 1 commit intorelatiocc:mainfrom Nov 20, 2025
commonly-ts:main
Merged
fix(universes): Update PATCH request body to include gameJoinRestriction#8marinofranz merged 1 commit intorelatiocc:mainfrom commonly-ts:main
marinofranz merged 1 commit intorelatiocc:mainfrom
commonly-ts:main
Conversation
Oversight when I originally wrote this
Contributor
Author
|
I suspect Roblox made internal changes which makes not wrapping the body in |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
marinofranz
approved these changes
Nov 20, 2025
Member
marinofranz
left a comment
marinofranz
left a comment
There was a problem hiding this comment.
Good eye, let's merge this 🎉
github-actions bot
pushed a commit
that referenced
this pull request
Nov 20, 2025
## [1.10.2](v1.10.1...v1.10.2) (2025-11-20) ### Bug Fixes * **universes:** update PATCH request body to include gameJoinRestriction ([#8](#8)) ([638a4e7](638a4e7))
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The body when needs to be wrapped in
gameJoinRestrictionwhich somehow wasn't an issue when I did manual testingFixes #
Type of Change
Changes Made
Wraps
bodyinside ofgameJoinRestrictionin the PATCH requestAll existing tests pass (
pnpm test)Added new tests for new functionality
Tested manually (describe below)
Manual Testing
None done, the PATCH request aligns with Roblox's documentation.
Code Quality
pnpm lintand fixed any issuespnpm formatto format my codepnpm typecheckand there are no type errorsDocumentation
Additional Context
Checklist
mainbranch