Skip to content

fix: fallback to UPLOAD heapType for devices without GPU_UPLOAD support #92

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
dreamsyntax wants to merge 2 commits into from
Closed

fix: fallback to UPLOAD heapType for devices without GPU_UPLOAD support #92

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
44ae897
fix: fallback to UPLOAD heapType
dreamsyntax Mar 15, 2026
fb38245
Apply suggestion from @DarioSamo
DarioSamo Mar 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions plume_d3d12.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -465,7 +465,7 @@ namespace plume {
}
}

static D3D12_HEAP_TYPE toD3D12(RenderHeapType type) {
static D3D12_HEAP_TYPE toD3D12(RenderHeapType type, bool gpuUploadHeapFallback) {
switch (type) {
case RenderHeapType::DEFAULT:
return D3D12_HEAP_TYPE_DEFAULT;
Expand All @@ -474,7 +474,7 @@ namespace plume {
case RenderHeapType::READBACK:
return D3D12_HEAP_TYPE_READBACK;
case RenderHeapType::GPU_UPLOAD:
return D3D12_HEAP_TYPE_GPU_UPLOAD;
return gpuUploadHeapFallback ? D3D12_HEAP_TYPE_UPLOAD : D3D12_HEAP_TYPE_GPU_UPLOAD;
default:
assert(false && "Unknown heap type.");
return D3D12_HEAP_TYPE_DEFAULT;
Expand Down Expand Up @@ -2757,7 +2757,7 @@ namespace plume {

D3D12MA::ALLOCATION_DESC allocationDesc = {};
allocationDesc.Flags = desc.committed ? D3D12MA::ALLOCATION_FLAG_COMMITTED : D3D12MA::ALLOCATION_FLAG_NONE;
allocationDesc.HeapType = toD3D12(desc.heapType);
allocationDesc.HeapType = toD3D12(desc.heapType, device->gpuUploadHeapFallback);
allocationDesc.CustomPool = (pool != nullptr) ? pool->d3d : nullptr;

HRESULT res = device->allocator->CreateResource(&allocationDesc, &resourceDesc, resourceStates, nullptr, &allocation, IID_PPV_ARGS(&d3d));
Expand Down Expand Up @@ -2931,7 +2931,7 @@ namespace plume {
poolDesc.HeapProperties = device->d3d->GetCustomHeapProperties(0, D3D12_HEAP_TYPE_UPLOAD);
}
else {
poolDesc.HeapProperties.Type = toD3D12(desc.heapType);
poolDesc.HeapProperties.Type = toD3D12(desc.heapType, gpuUploadHeapFallback);
}

poolDesc.MinBlockCount = desc.minBlockCount;
Expand Down