Open
Conversation
|
Any reason this hasn't been merged? |
|
Monthly reminder to check on this! |
Member
|
There's a lot of duplicated code in this pull request, and it doesn't have any automated tests to cover the new functionality. Can you fix those problems? I'm happy to help, if you're not sure how. |
Contributor
|
Since this hasn't been updated in a while, thought I'd chime in. #361 |
Author
|
Thank you @AdamGold! I was just getting back to this, but looks like you already got it done. |
Member
|
I've tried to pull the actual code changes out into a separate pull request: #369. Could you please review that, and tell me if it solves your problem? |
|
Since #369 has been merged, can we close this? it appears from the PR's page that this issue was never resolved. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A private API I'm working with requires that the request body be sent as a query string in the url. It's possible that others have encountered the same problem. I allow for this option in this pull request.