Skip to content

feat(public-search): display disabled request button with tooltip #1399

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: staging
Choose a base branch
from
Open

feat(public-search): display disabled request button with tooltip #1399

wants to merge 1 commit into from

Conversation

@PascalRepond
Copy link
Contributor

@PascalRepond PascalRepond commented Dec 3, 2025

  • Only when the patron has reached the maximum number of active loans, fees, or requests, the request button is now displayed in the public UI but disabled with a tooltip explaining the reason. This allows patron to understand why they cannot place a request.
  • Depends on refact(permissions): add codes to can request api rero-ils#3992.

@github-actions github-actions bot added the f: public ui Public interface, as opposed to the professional interface label Dec 3, 2025
@PascalRepond PascalRepond requested review from Garfield-fr and jma and removed request for Garfield-fr December 3, 2025 10:27
@github-actions github-actions bot added f: circulation Concerns the circulation interface or backend f: user management labels Dec 3, 2025
Garfield-fr
Garfield-fr approved these changes Dec 3, 2025
View reviewed changes
@Garfield-fr

This comment was marked as resolved.

Sign in to view
@PascalRepond PascalRepond force-pushed the rep-request-button branch 2 times, most recently from 15a9a9e to 19dcc29 Compare December 4, 2025 07:33
@github-actions github-actions bot added the f: professional ui Professional interface label Dec 4, 2025
jma
jma approved these changes Dec 4, 2025
View reviewed changes
@PascalRepond PascalRepond force-pushed the rep-request-button branch 5 times, most recently from 0faa224 to b8c799e Compare December 4, 2025 11:04
@PascalRepond
feat(public-search): display disabled request button with explanatory…
49e09ce 
… tooltip

* Only when the patron has reached the maximum number of
  active loans, fees, or requests, the request button is now displayed
  in the public UI but disabled with a tooltip explaining the reason.
  This allows patron to understand why they cannot place a request.
* Depends on rero/rero-ils#3992.

Co-Authored-by: Pascal Repond <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Garfield-fr Garfield-fr Garfield-fr approved these changes

@jma jma jma approved these changes

Assignees

@PascalRepond PascalRepond

Labels

f: circulation Concerns the circulation interface or backend f: professional ui Professional interface f: public ui Public interface, as opposed to the professional interface f: user management

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@PascalRepond @Garfield-fr @jma