Skip to content

Fix api doc page not scrollable #1180

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
lungarella-raffaele wants to merge 1 commit into from
Closed

Fix api doc page not scrollable #1180

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 13 additions & 7 deletions src/ApiDocs.res
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -288,13 +288,19 @@ module DocstringsStylize = {

let make = (props: props) => {
let (_, setScrollLock) = ScrollLockContext.useScrollLock()
let (isSidebarOpen, setSidebarOpen) = React.useState(_ => true)

let toggleSidebar = () =>
setSidebarOpen(prev => {
setScrollLock(_ => !prev)
!prev
})
let isMobile = Hooks.useIsMobile()
let (isSidebarOpen, setSidebarOpen) = React.useState(_ => false)

React.useEffect(() => {
setSidebarOpen(_ => !isMobile)
None
}, [isMobile])

let toggleSidebar = () => {
let nextSidebarOpen = !(isSidebarOpen && isMobile)
setSidebarOpen(_ => nextSidebarOpen)
setScrollLock(_ => nextSidebarOpen && isMobile)
}

let children = {
open Markdown
Expand Down
18 changes: 18 additions & 0 deletions src/common/Hooks.res
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,3 +69,21 @@ let useScrollDirection = (~topMargin=80, ~threshold=20) => {

scrollDir
}

let useIsMobile = (~breakpoint=768) => {
let (isMobile, setIsMobile) = React.useState(() => false)

React.useEffect(() => {
let check = () => window.innerWidth < breakpoint
setIsMobile(_ => check())

let onResize = _ => {
setIsMobile(_ => check())
}

WebAPI.Window.addEventListener(window, Resize, onResize)
Some(() => WebAPI.Window.removeEventListener(window, Resize, onResize))
}, [breakpoint])

isMobile
}
Loading