Fix api doc page not scrollable#1180
Fix api doc page not scrollable#1180lungarella-raffaele wants to merge 1 commit intorescript-lang:masterfrom
Conversation
|
I think some of this, or all of this, is fixed by: #1156 @fhammerschmidt mentioned another issue, but I think it's best to try and get that merged in before any other scrolling or layout fixes. |
|
Yeah but only if you dont introduce new layout issues check my last comment) |
|
I closed out the other PR, so I think we should go ahead with this fix. @lungarella-raffaele if you pull from master I think we should be able to have a cloudflare preview run so we can test things. |
15f620f to
0d25b9a
Compare
|
Let me know if I can do something to fix the build :) |
It's a permission issue on the GitHub action and some missing env variables that aren't accessible by forks. I feel like we should be able to figure it out. |
|
I believe #1186 solves this as well? |
|
@lungarella-raffaele Sorry, I didn't notice that there already were PRs open to address this issue... |
|
No worries, I will close the pr since the bug is fixed 🎉 |
Fixes part of #1162
This addresses a sidebar state management issue where the scrollbar behavior and sidebar state aren't properly coordinated.
I think the intended behavior should be:
However, the current implementation has some issues:
isSidebarOpenflashes fromtruetofalseeven when the sidebar is clearly visiblescrollLockandisSidebarOpenon all screen sizes, even though this behavior should only apply to mobile (I think)I've updated the logic so that sidebar state management primarily matters on mobile, with the sidebar defaulting to open on larger screens, but I had to add an hook to check if we are on mobile with an hardcoded breakpoint
This makes the docs more usable, but I'd love feedback on how to improve it! 🙂