Skip to content

Fix README Match section to match implementation#13

Merged
monneyboi merged 1 commit intomainfrom
fix/readme-match-section-12
Mar 7, 2026
Merged

Fix README Match section to match implementation#13
monneyboi merged 1 commit intomainfrom
fix/readme-match-section-12

Conversation

@claude
Copy link

@claude claude bot commented Mar 7, 2026

Summary

  • Replace stale description of "literal name nodes" with "is named" edges — the code actually seeds entity-entity confidence directly from Soft TF-IDF name similarity before the propagation loop
  • Remove reference to a 0.5 confidence gate that doesn't exist — the code skips neighbor pairs with zero confidence (<= 0.0), not 0.5

Closes #12

Test plan

  • Verified updated text matches match.py lines 229-242 (name similarity seeding) and line 259 (<= 0.0 check)
  • Confirmed remaining Match section content (exponential sum, functionality, relation embeddings, dangling entities) is still accurate

🤖 Generated with Claude Code

Update the Match section to accurately describe how name similarity
seeds the confidence dict before propagation (not via literal name
nodes), and remove the stale reference to a 0.5 confidence gate.

Closes #12

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@monneyboi monneyboi closed this Mar 7, 2026
@monneyboi monneyboi reopened this Mar 7, 2026
@monneyboi monneyboi merged commit f41bf8f into main Mar 7, 2026
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

README describes stale name-as-node architecture

1 participant