Skip to content

Fix redundant build_unified_graph call in run_matching#18

Merged
monneyboi merged 1 commit intomainfrom
fix/deduplicate-unified-graph-build
Mar 7, 2026
Merged

Fix redundant build_unified_graph call in run_matching#18
monneyboi merged 1 commit intomainfrom
fix/deduplicate-unified-graph-build

Conversation

@claude
Copy link

@claude claude bot commented Mar 7, 2026

Summary

  • build_match_groups now returns (match_groups, unified_graph) instead of just match_groups, so the caller can reuse the unified graph it already builds internally
  • Removes the redundant second build_unified_graph(graphs) call in run_matching
  • Updates test call sites to unpack the new return tuple

Closes #14

Test plan

  • All 50 existing tests pass (no behavior change, just eliminating redundant work)

🤖 Generated with Claude Code

build_match_groups now returns (match_groups, unified_graph) so
run_matching can reuse the graph instead of rebuilding it.

Closes #14

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@monneyboi monneyboi closed this Mar 7, 2026
@monneyboi monneyboi reopened this Mar 7, 2026
@monneyboi monneyboi merged commit 1a6807f into main Mar 7, 2026
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Redundant build_unified_graph call in run_matching

1 participant