Conversation
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…adge, ActionResultBanner, SearchInput) Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…d delete Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…, repair, and issue management Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…te, and redeploy Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…agement Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This reverts commit 633cda1.
ericokuma
left a comment
There was a problem hiding this comment.
Re-review: Issues Found & Fixed
After re-reviewing the current state of the PR, I identified and fixed the following issues:
Fixed in this pass
-
Auth guard control flow clarity (
+layout.ts): Restructured the catch block soredirectToLogin()is only called inside the 401 branch, with non-401 errors always throwing a redirect. Same behavior, clearer intent. -
Unreachable code (
+page.svelteUsers): RemovednotifySuccess()call afterassumedUser.assume()— sinceassume()setswindow.location.href, the notification never displays. -
Unfiltered
invalidateQueries()(superusers/+page.svelte): Both add and remove handlers calledqueryClient.invalidateQueries()with no filter, invalidating every query in the app. Scoped to/v1/superuserqueries. -
Unfiltered
invalidateQueries()(billing/+page.svelte):handleDeleteIssueinvalidated all queries. Scoped to/v1/organizationsand/v1/superuser/billing. -
ConfirmDialogcloses on error (ConfirmDialog.svelte): IfonConfirmthrew, the dialog would close via thefinallyblock, hiding the error. Added acatchblock so the dialog stays open on failure, letting users retry or cancel.
Not applicable
- Annotations page, whitelist page, and
OrgHeadercomponent do not exist in the current diff — these were false positives from the earlier review. superuserForceAccessongetOrgProjects: theAdminServiceListProjectsForOrganizationParamstype does not include this field, so no change needed.
Developed in collaboration with Claude Code
…eview issues - Fix mutateAsync param names: organization → org for hibernate/redeploy - Fix billing issue type to use V1BillingIssueType enum instead of string - Fix quota fields: convert API numbers to strings for form binding - Remove invalid superuserForceAccess from deleteUser call - Scope invalidateQueries in superusers and billing pages instead of invalidating all - Fix ConfirmDialog to keep dialog open on error for retry - Clean up auth guard control flow in admin layout - Remove unreachable notifySuccess after assume navigation - Fix a11y: change label to span for non-input billing text Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Add new shared components (OrgSearchInput, UserSearchInput, notify, RepresentingBanner, assume-state) that were missing from previous commits. Remove obsolete pages (annotations, runtime, users, virtual-files, whitelist) and unused components (ActionResultBanner, StatusBadge, whitelist selectors) that were deleted locally but not staged. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
- Remove Dashboard, Whitelist, and Advanced nav sections from sidebar - Point Users link to root admin page (/-/admin) - Fix users/selectors: use emailPattern with wildcards, threshold >= 3, remove unused assume/unassume mutations - Fix projects/selectors: add wildcard wrapping, threshold >= 3 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
… mount assume banner - Move Admin Console link from top nav (OrgHeader) to profile dropdown (AvatarButton), removing duplicate ListSuperusers query from OrgHeader - Add missing getBillingSetupURL function to billing selectors (was imported but never defined, causing 500 on billing page) - Mount RepresentingBanner in root layout so assume-user banner appears when browsing as another user Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
…sses svelte-check cannot parse `@apply` with `dark:` variants in `<style lang="postcss">` blocks, causing 12 CI errors and broken dark mode. Move all utility classes inline across 13 admin console files and remove `<style>` blocks entirely. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
…ariants Add explicit bg-white/dark:bg-slate-900 to admin layout wrapper and bg-slate-50/dark:bg-slate-950 to content area. Add dark:text-slate-400 to all loading/empty state text that was missing dark variants. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
…ables Rill's Tailwind color palette (slate, blue, red, etc.) uses CSS custom properties that already swap between light and dark values. Using dark: prefixed classes caused double-inversion. Remove all dark: variants and replace bg-white with bg-slate-50 which auto-adapts. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
ill play with in Monday but from the Video a few comments:
Projects
|
Adds an internal super admin console to
web-adminat/-/admin/, giving non-technical staff (CS, account managers) a GUI for operations currently only available viarill sudoCLI commands./-/admin/with superuser-gated auth guard (ListSuperuserscheck)OrgHeadervisible only to superusersChecklist:
Developed in collaboration with Claude Code