feat: step 2 Show project Status tab to editors in Cloud and Developer #9358
Open
feat: step 2 Show project Status tab to editors in Cloud and Developer #9358
Conversation
royendo
changed the title
royendo
changed the title
8 tasks
royendo
force-pushed
the
royendo/show-status-tab-to-editors
branch
from
8c74ffd to
87133eb
Compare
Gate the Status tab on `readProdStatus` instead of `manageProject` so editors (not just admins) can view deployment status. The `read_prod_status` permission is already true for admin and editor roles and false for viewers, matching the desired access. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Map `read_prod_status` / `read_dev_status` to `runtime.ReadInstance` so
non-managers (editors) can call `GetInstance({ sensitive: true })`.
Without this, the Status page's Tables sub-page hangs forever for
editors because it can't resolve the OLAP connector name.
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
`status/+layout.ts` (added in #9311) gates direct-URL access on `manageProject`, which would block editors who can now see the Status tab. Loosen the gate to `readProdStatus` to match the nav. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
royendo
force-pushed
the
royendo/show-status-tab-to-editors
branch
from
445d570 to
5ceaa70
Compare
| } | ||
| if readDeplStatus { | ||
| // Status visibility: lets non-managers (e.g. editors) view the project Status page. | ||
| instancePermissions = append(instancePermissions, runtime.ReadInstance) |
Contributor
There was a problem hiding this comment.
This is not quite sufficient; it needs some extra checks, and also needs to update some permission checks on the runtime side. Implemented the correct checks here: #9372
Contributor
|
This is not quite sufficient; it needs some extra checks, and also needs to update some permission checks on the runtime side. Implemented the correct checks here: #9372 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
requires: #9359
Gate the project Status tab on
readProdStatusinstead ofmanageProjectso editors can view deployment status.read_prod_statusis alreadytrueforadminandeditorroles andfalseforviewer(peradmin/database/postgres/migrations/0003.sql), matching the access we want./-/status(overview, branches, resources, tables, logs) are already permitted for any user who reaches the section.manageProject.Checklist:
Developed in collaboration with Claude Code