Drive edit session timeout banner from used_on and dev_ttl_seconds#9389
Merged
ericpgreen2 merged 3 commits intomainfrom May 6, 2026
Merged
Drive edit session timeout banner from used_on and dev_ttl_seconds#9389ericpgreen2 merged 3 commits intomainfrom
used_on and dev_ttl_seconds#9389ericpgreen2 merged 3 commits intomainfrom
Conversation
The banner previously approximated the hibernation time as `deployment.created_on + 1 hour`, which drifts from the real backend behavior (`used_on + project.dev_ttl_seconds`). Expose both fields on the admin API and use them in the banner directly.
…it-session-timeout-banner # Conflicts: # proto/gen/rill/admin/v1/api.pb.go
AdityaHegde
approved these changes
May 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The edit session timeout banner previously approximated the hibernation time client-side as
deployment.createdOn + 1h, which doesn't match the real backend behavior. The runtime hibernates a deployment whennow - deployment.used_on > project.dev_ttl_seconds, but neither field was exposed on the admin API.Project.dev_ttl_seconds(proto field 27) andDeployment.used_on(proto field 14) on the admin API.projToDTOanddeploymentToDTO.EditSessionTimeoutBannerfromusedOn + devTtlSecondsinstead of the hardcoded one-hour TTL; treat missing or zero TTL as "no banner".Discussed in Slack.
Checklist:
Developed in collaboration with Claude Code