Isolate DeveloperChat and DashboardChat sidebar state#9393
Draft
ericpgreen2 wants to merge 1 commit intomainfrom
Draft
Isolate DeveloperChat and DashboardChat sidebar state#9393ericpgreen2 wants to merge 1 commit intomainfrom
DeveloperChat and DashboardChat sidebar state#9393ericpgreen2 wants to merge 1 commit intomainfrom
Conversation
- Remove the `<DashboardChat />` wrapper in `/-/edit/explore/[name]` so editor sub-routes render only the developer agent. - Split the sidebar store into per-surface `developerChatOpen`/ `dashboardChatOpen` and `developerChatActions`/`dashboardChatActions`. `SidebarChat` and `ChatToggle` now take the surface's actions/open as props. - Scope `BrowserStorageConversationSelector` storage key by surface, so a dev-runtime conversation ID does not load against the prod runtime when a Publish-spawned tab inherits sessionStorage.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Polishing the in-flight cloud editing feature on two fronts:
/-/edit/...should have a single AI surface — the developer agent. Today, viewing a dashboard preview inside the editor mounts both<DeveloperChat />(root edit layout) and<DashboardChat />(the/-/edit/explore/[name]wrapper layout), gated on the samechatOpenflag. With both feature flags enabled the user sees two AI panels side-by-side. Removing the dashboard chat in editor routes also moves us toward the future where one Rill Developer AI surface handles both developer and analyst work.chat-open=truecarries over (so the prod sidebar appears open by default) and the dev-runtime conversation ID is loaded against the prod runtime, leading to an "Unable to find this conversation" error.Implementation:
/-/edit/explore/[name]/+layout.svelte, the wrapper that mounted<DashboardChat />next to the editor's<DeveloperChat />. Suppress the dashboard<ChatToggle />inProjectHeader.sveltewheneditContextis true.chatOpen/sidebarActionsinto per-surfacedeveloperChatOpen/developerChatActionsanddashboardChatOpen/dashboardChatActions.SidebarChatandChatTogglenow accept the surface'sopen/actionsas props; non-component callers (ExplainAndFixErrorButton,chart-ai-agent,generateCanvas,generate-sample-data,measure-selection, embed public API) wire to their explicit surface.BrowserStorageConversationSelectorstorage key by surface:sidebar-conversation-id-{surface}-{org}-{project}.Checklist:
Developed in collaboration with Claude Code