fix(agent): expose Gemini diff snapshot directories#719
Merged
mariusvniekerk merged 1 commit intoMay 14, 2026
Merged
Conversation
Mirrors the codex fix from roborev-dev#699: large diff prompts reference a roborev-snapshot-* file in the system temp dir, but gemini's workspace does not include that path, so it refuses to read the diff. Detect the snapshot dirs referenced in the prompt and pass each to gemini via --include-directories. The detection helper is now shared between codex and gemini in a new internal/agent/snapshot_dirs.go.
roborev: Combined Review (
|
|
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/tmp/roborev-snapshot-*/roborev-snapshot-*.difffile, gemini's workspace doesn't include that path and it refuses to read the diff, returning an empty / system-environment-flagged review.--include-directoriesso gemini can read them.codex.go) intointernal/agent/snapshot_dirs.goso both agents share one implementation.