Add Docs Expo Integration (expo-sqlite & op-sqlite)#84
Add Docs Expo Integration (expo-sqlite & op-sqlite)#84austinm911 wants to merge 2 commits intorocicorp:mainfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
LGTM |
austinm911
changed the title
arv
left a comment
arv
left a comment
There was a problem hiding this comment.
LGTM
This is very useful... going to look at the mono PR now.
| [userId, authToken], | ||
| ); | ||
|
|
||
| if (!z) { |
There was a problem hiding this comment.
good point - on the other hand do you want this to be simplified and exclude using the useMemo in the docs (but we can keep the comment about in production it should be memoized). Elsewhere in the docs it is kept simple.
| href: string; | ||
| noLink?: true; | ||
| items?: EachRoute[]; | ||
| title: string; |
There was a problem hiding this comment.
formatting change seems a bit odd.
maybe run npm run format
|
@aboodman - do we want to go ahead and merge this? Looks like it got stuck because the formatting of |
|
I was planning to look at this in deeper details (maybe next week or after the vacation end of the month) |
aboodman
force-pushed
the
main
branch
5 times, most recently
from
a492bc6 to
d8dc28a
Compare
4 participants
See rocicorp/mono#3841