Open
Conversation
jshufro
force-pushed
the
jms/integrated-updates
branch
from
1613202 to
3ad84d7
Compare
Contributor
Author
|
Adding signature verification and reopening |
jshufro
force-pushed
the
jms/integrated-updates
branch
from
50e8dc2 to
8cf1788
Compare
jshufro
force-pushed
the
jms/integrated-updates
branch
from
8cf1788 to
cd7ae28
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
N.B. The last commit is utterly boring conversions of
prompt.Confirm(fmt.Sprintf(...))to justprompt.Confirm(). It was created with the help of AI. Without it, the tests fail due to lint errors.The commits with meaty changes are these:
For testing, you will want to build the cli and then run
rocketpool update --force, otherwise it won't replace itself because the version numbers will match (runrocketpool updateas well to verify this).After each time you run the command, the binary will be replaced by whatever is on github, so you will need to rerun the build to get back the functionality.
rocketpool update --force -yworks to auto-accept prompts and always overwrite.Please please please find a volunteer to test this on OSX. It should work, but I don't have the hw to test it.