Replace deprecated alias Zmod with Z.modulo#134
Merged
spitters merged 1 commit intorocq-community:masterfrom May 9, 2025
Merged
Replace deprecated alias Zmod with Z.modulo#134spitters merged 1 commit intorocq-community:masterfrom
spitters merged 1 commit intorocq-community:masterfrom
Conversation
Contributor
Author
|
The CI failure appears unrelated: |
Collaborator
|
Thanks! Could the CI issue be due to the name change? I guess it's something that shows up on many places on the platform. |
Contributor
|
Fix ci #135 |
Collaborator
|
Thanks @SkySkimmer ! I've restarted the CI. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change adapts math-classes for a future stdlib PR removing Zmod.
The current definition of
Zmodin stdlib is as follows:I am looking to remove that definition shortly, and to reuse the name for something incompatible.
Thanks!