Decouple template rendering via BaseConfig.render()#31
Merged
rafa-guedes merged 5 commits intomainfrom Feb 26, 2026
Merged
Conversation
Add render() method to BaseConfig that delegates to cookiecutter renderer. This enables configs to override rendering behavior while maintaining backward compatibility with existing template-based rendering.
Add unit test verifying ModelRun.generate() calls config.render() with correct arguments. Test uses mock to intercept render() and validate delegation behavior.
Update ModelRun.generate() to call config.render() instead of directly calling rompy.core.render.render(). This decouples rendering logic from ModelRun and allows configs to customize rendering behavior.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
BaseConfig.render(context, output_dir) -> stras an overridable hook that delegates to the existing cookiecutter renderer by default.ModelRun.generate()to callconfig.render(...)instead of importing/callingrompy.core.render.renderdirectly.ModelRun.generate()delegates toconfig.render(...).Why
ModelRun.generate()previously hard-coded cookiecutter rendering and assumed configs always expose.templateand.checkout. Moving rendering responsibility to the config object decouples orchestration from implementation and enables alternative rendering strategies via overrides.Verification
pytest -q(340 passed, 4 skipped)pytest tests/test_config_render_delegation.py -qandpytest tests/test_templates.py -qCommits
Fixes #30