Fix PyPI upload failure by removing git dependency#33
Merged
tomdurrant merged 1 commit intomainfrom Mar 6, 2026
Merged
Conversation
PyPI does not allow direct git dependencies in package metadata, even in optional extras. The rompy-notebooks dependency was causing PyPI upload failures with error: 'Can't have direct dependency: rompy-notebooks @ git+https://github.com/rom-py/rompy-notebooks.git@package'. This dependency is not needed for package distribution since the docs build workflow already clones rompy-notebooks directly from GitHub and copies the notebooks into the docs directory during the build process.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes the
notebooksoptional dependency that was causing PyPI upload failures.Problem
The v0.6.3 release failed to upload to PyPI with this error:
PyPI does not allow direct git dependencies in package metadata, even in optional extras, because they are not reproducible or verifiable according to PEP 440.
Solution
Removed the
notebooksoptional dependency frompyproject.toml. This dependency is not needed for package distribution because:.github/workflows/build-docs.yml) already clonesrompy-notebooksdirectly from GitHubpip install .[docs], not[notebooks]Testing
Fixes the PyPI upload failure in release v0.6.3.