Skip to content

Conversation

@cottsay
Copy link
Member

@cottsay cottsay commented Dec 2, 2025

This reverts #48703.

The 4.3.0-3 release, which is an update from 4.3.0-2, contains a multitude of changes which are not possible with only a debinc bump. For debian builds, such substantial changes to the underlying sources require a version bump of some kind.

Failing buildfarm job: https://build.ros2.org/view/Kbin_uN64/job/Ksrc_uN__gtsam__ubuntu_noble__source/4/

@jlblancoc FYI

@cottsay cottsay self-assigned this Dec 2, 2025
@cottsay cottsay added the kilted Issue/PR is for the ROS 2 Kilted distribution label Dec 2, 2025
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for sending a pull request to ROS distro!

This is an automated tool that helps check your pull request for correctness.
This tool checks a number of attributes associated with your ROS package and generates a report that helps our reviewers merge your pull request in a timely fashion. Here are a few things to consider when sending adding or updating a package to ROS Distro.
ROS Distro includes a very helpful CONTRIBUTING.md file that we recommend reading if it is your first time submitting a package.
Please also read the ROS Distro review guidelines which summarizes this release process.

ROS Distro Considerations

Package Considerations

Having your package included in a ROS Distro is a badge of quality, and we recommend that package developers strive to create packages of the highest quality. We recommend package developers review the following resources before submitting their package.

Need Help?

Please post your questions to Robotics Stack Exchange or refer to the #infra-help channel on our Discord server.


For changes related to yamllint:

  • ✅ All new lines of YAML pass linter checks

@jlblancoc
Copy link
Contributor

Thanks for the pointers, @cottsay . I mentioned this on discourse since wasn't sure how to treat incremental "alpha" releases upstream. Sadly, the old version you are rolling back, IIRC, had some build errors hence the need to upgrade it.

I guess the only solution is to remove this package (or let it be removed on the next sync since it's failing to build) and re-release again?? 🙄

It seems there are no short-term plans upstream to make new stable releases...

@cottsay
Copy link
Member Author

cottsay commented Dec 2, 2025

how to treat incremental "alpha" releases upstream.

I don't have any good ideas here, unfortunately.

the old version ... had some build errors

The 4.3.0-2 release appears to be building successfully on Ubuntu Noble amd64, but I see now that the last version to build successfully on Noble arm64 and RHEL 9 was 4.2.0-7. Should we revert back to that version instead, while a new solution for releasing the package is devised?

@cottsay
Copy link
Member Author

cottsay commented Dec 2, 2025

To unblock the current regressions, I'm going to merge this revert PR so that we can unblock the Kilted sync. It's not a solution though.

@cottsay cottsay merged commit 2588451 into ros:master Dec 2, 2025
5 checks passed
@cottsay cottsay deleted the revert-gtsam branch December 2, 2025 17:38
@jlblancoc
Copy link
Contributor

@cottsay
I guess we should roll back to the even older version 4.2.0-7 that built on all archs. I could do the PR here if you want.

After that, perhaps the only solution to allow an eventual final release 4.3.0 (non "alpha"!) is to manually remove the "4.3*" tags and branches on the gbp repo...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kilted Issue/PR is for the ROS 2 Kilted distribution

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants