rosdep entry for libjson-c-dev and question for libjson0-dev #48868
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Thanks for sending a pull request to ROS distro!
This is an automated tool that helps check your pull request for correctness.
This tool checks a number of attributes associated with your ROS package and generates a report that helps our reviewers merge your pull request in a timely fashion. Here are a few things to consider when sending adding or updating a package to ROS Distro.
ROS Distro includes a very helpful CONTRIBUTING.md file that we recommend reading if it is your first time submitting a package.
Please also read the ROS Distro review guidelines which summarizes this release process.
ROS Distro Considerations
- ROS Distributions are created using REP-134 Standards Track as a guide.
- Your package name should comply to REP-144 ROS Package Naming
- Your package must build for all platforms and architectures on the ROS buildfarm. See REP-2000 ROS Releases and Supported Platforms for all supported platforms for your ROS Distro.
- Your package must contain an OSI approved license. Your
package.xmlfile must also include that license in a machine readable format. See REP-149 Package Manifest Format Three Specification for additional details. - A publicly available, open source, repository for your ROS package.
- While not required, we recommend that you create an account for ROS Discourse and subscribe to the appropriate release topic.
- If you would like, you may join our Discord Server and ask questions in the
#infra-helpchannel.
Package Considerations
Having your package included in a ROS Distro is a badge of quality, and we recommend that package developers strive to create packages of the highest quality. We recommend package developers review the following resources before submitting their package.
- REP-2004 Package Quality Declaration-- The ROS 2 TSC has created a quality rating system for ROS packages. These ratings should serve as a guide for package developers. We recommend package developers achieve a quality level of three or higher.
- Documentation -- it is recommended that ROS packages include an extensive README.md file, and API level documentation using the Sphinx documentation system.
- Maintainer Responsibilities -- the ROS 2 documentation includes a guide to ROS package maintainer responsibilities that summarizes your responsibilities as an open source maintainer. While we do not enforce these requirements on package maintainers they should be considered best practices.
- We recommend that your package should strive to conform to the ROS 2 Developer Guide and the ROS 2 Style Guide.
Need Help?
Please post your questions to Robotics Stack Exchange or refer to the #infra-help channel on our Discord server.
For changes related to rosdep:
- ✅ New rosdep keys are named appropriately
- ✅ Platforms for new rosdep rules are valid
- ✅ New keys appear suitable for rosdep
For changes related to yamllint:
- ✅ All new lines of YAML pass linter checks
vtalpaert
force-pushed
the
rosdep-libjson-c-dev
branch
from
8bc38b9 to
9eeee7d
Compare
1 participant
Please add the following dependency to the rosdep database.
Package name:
libjson-c-dev
Package Upstream Source:
https://github.com/json-c/json-c
Purpose of using this:
The development headers for json-c are not available for Ubuntu in rosdep. The closest key is
libjson0-devbut it does not correspond to an existing package for Ubuntu nor Debian. This last key is a mix of non existing packages with the real json-c-dev.I leave to the reviewers the decision about
libjson0-dev, which could be removed or updated to the json-c devel packages so that it is at least consistent among the distributions.This PR adds a new key,
libjson-c-devwith the packages as bellow :Distro packaging links:
Links to Distribution Packages