Skip to content

feat: add base rpc extractor#8

Open
mgpai22 wants to merge 2 commits into
rosen-bridge:devfrom
mgpai22:mgpai22/base-integration
Open

feat: add base rpc extractor#8
mgpai22 wants to merge 2 commits into
rosen-bridge:devfrom
mgpai22:mgpai22/base-integration

Conversation

@mgpai22
Copy link
Copy Markdown

@mgpai22 mgpai22 commented Apr 22, 2026

Summary

Add the Base RPC observation extractor.

Changes

  • add Base EVM observation extractor
  • export the new extractor from the package index

Notes

  • follows the existing Ethereum and Binance extractor pattern

Copy link
Copy Markdown
Member

@RaaCT0R RaaCT0R left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 Required Change

Please pull the latest version in dev and resolve conflicts. Also make sure you're using the latest version of the dependencies in the new package.

Comment on lines +2 to +5
'@rosen-bridge/evm-observation-extractor': minor
---

Add a Base RPC observation extractor alongside the shared EVM extractor exports.
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Text Improvement

I'm not sure what you mean by "alongside the shared EVM extractor exports".

Suggested change
'@rosen-bridge/evm-observation-extractor': minor
---
Add a Base RPC observation extractor alongside the shared EVM extractor exports.
'@rosen-bridge/evm-observation-extractor': minor
---
Add Base RPC observation extractor

lockAddress,
tokens,
'base',
'eth',
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 Required Change

The ETH on Base (it's native token) will be not bridgeable and the token ID should be unique in our system. So we use this string for ETH on Base:

Suggested change
'eth',
'eth-base',

Comment thread package-lock.json
"license": "MIT",
"optional": true
"optional": true,
"peer": true
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 Required Change

These changes in package-lock seems wrong.

Please revert this file to latest version in dev, make sure you're using node v22 and npm v11.6.2 and then install packages.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants