Skip to content

Conversation

@gustavosimon
Copy link
Contributor

No description provided.

Copilot AI review requested due to automatic review settings December 16, 2025 21:43
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds support for recognizing .cpy and .cpb file extensions as COBOL files in the Rouge syntax highlighter. These are standard COBOL copybook file extensions commonly used in COBOL development. The changes enable the lexer to properly identify and highlight these file types alongside the existing .cob and .cbl extensions.

Key changes:

  • Added .cpy and .cpb to the list of recognized COBOL file extensions
  • Added corresponding test coverage for the new file extensions

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
lib/rouge/lexers/cobol.rb Updated filenames declaration to include *.cpy and *.cpb extensions
spec/lexers/cobol_spec.rb Added test assertions to verify filename guessing works for .cpy and .cpb files

After thoroughly reviewing the changes, I found no issues with this pull request. The implementation is clean, follows the established patterns in the codebase, and properly adds both the lexer support and corresponding test coverage. The .cpy (copybook) and .cpb (copybook) extensions are legitimate COBOL file extensions used in the COBOL community, particularly for files containing reusable code snippets that are copied into other programs during compilation.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@gustavosimon
Copy link
Contributor Author

@tancnle @pyrmont maybe you can take a look in this PR?

@pyrmont
Copy link
Contributor

pyrmont commented Dec 16, 2025

I'm sorry, @gustavosimon. I'm no longer a maintainer on this project.

@tancnle
Copy link
Collaborator

tancnle commented Dec 31, 2025

Thanks, @gustavosimon. LGTM 🚀

@tancnle tancnle added this pull request to the merge queue Dec 31, 2025
Merged via the queue into rouge-ruby:master with commit 287002c Dec 31, 2025
16 checks passed
@gustavosimon
Copy link
Contributor Author

gustavosimon commented Dec 31, 2025

Thanks, @gustavosimon. LGTM 🚀

Great, thanks for approving @tancnle!
Can we release this change soon?
I would like to update the version in the GitLab!

@tancnle
Copy link
Collaborator

tancnle commented Dec 31, 2025

@gustavosimon I have pushed a new release https://github.com/rouge-ruby/rouge/releases/tag/v4.7.0.

@gustavosimon
Copy link
Contributor Author

@gustavosimon I have pushed a new release https://github.com/rouge-ruby/rouge/releases/tag/v4.7.0.

Great!! Thanks a lot @tancnle ! Happy new year!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants