Saving dtypes as metadata for roundtrip consistency#262
Open
yfukai wants to merge 12 commits intoroyerlab:mainfrom
Open
Saving dtypes as metadata for roundtrip consistency#262yfukai wants to merge 12 commits intoroyerlab:mainfrom
yfukai wants to merge 12 commits intoroyerlab:mainfrom
Conversation
Contributor
Author
|
Notes:
|
Contributor
Author
|
Both tasks are done. I'll review the code for SQLgraph and mark this open for review. |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #262 +/- ##
==========================================
- Coverage 88.18% 87.70% -0.48%
==========================================
Files 56 56
Lines 4308 4531 +223
Branches 749 781 +32
==========================================
+ Hits 3799 3974 +175
- Misses 319 356 +37
- Partials 190 201 +11 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a follow-up on the dtype, assuming #260 has been merged.
In this PR, the graphs store the dtypes of the fields as metadata, enabling robust recovery of the original dtypes during round-trip
from_otherconversions.