Open
Conversation
cderv
requested changes
May 25, 2023
Collaborator
There was a problem hiding this comment.
it seems this broke some tests - we may need to adapt some processing to this change, especially if what is broken has been added after the --wrap=preserve addition.
Can you have a look to see why the specific test fails ? Otherwise I'll do it soon
Author
|
Tests pass on my computer (Pandoc version 2.19.2). Oh boy, this will be fun to debug... |
Author
|
Ok, partial improvement. I changed it to use wrap=preserve for gitbook, but only because that's the format that's testing #504, apparently. So this doesn't really fix the issue, it just seems to hide it. gitbook will still have #1430 unfixed and #504 might be broken in other formats, if I understand things correctly. Pandoc <= 2.16.2 fails a lot, though. No idea why. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This Closes #1430