fix(npx): auto-approve installable fallbacks#737
fix(npx): auto-approve installable fallbacks#737youbamj wants to merge 15 commits intortk-ai:developfrom
Conversation
golangci-lint v2 removed --out-format=json in favour of --output.json.path stdout. Detect the installed major version at runtime via golangci-lint --version and branch on the correct flag and JSON extraction strategy. - Use --output.json.path stdout for v2, --out-format=json for v1 - Extract JSON from first line only on v2 (v2 appends trailing metadata after JSON line) - Deserialise new v2 fields: SourceLines, Severity, Offset (serde default for v1 compat) - Show first source line per linter-file group on v2 for richer context - Always forward stderr to caller (was silently dropped unless --verbose) - Falls back to v1 behaviour on any version detection failure Signed-off-by: Adam Powis <a.powis.91@gmail.com>
Signed-off-by: YoubAmj <11021965+youbamj@users.noreply.github.com>
6fdddd2 to
a10d735
Compare
Signed-off-by: YoubAmj <11021965+youbamj@users.noreply.github.com>
Signed-off-by: YoubAmj <11021965+youbamj@users.noreply.github.com>
rake test ignores positional file arguments and only supports TEST=path for single-file runs. When users pass positional test files (e.g., `rtk rake test file1.rb file2.rb` or `rtk rake test file.rb:15`), select_runner() now switches to `rails test` which handles single files, multiple files, and line-number syntax natively. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Signed-off-by: Nicholas Lee <nicholas.lee@appfolio.com>
added script to act like release please (release please flag was unclear) added workflow dispatch event + dev like for prelease debug guards for workflow_dispatch (limit to push master for release events) Signed-off-by: aesoft <43991222+aeppling@users.noreply.github.com>
Signed-off-by: aesoft <43991222+aeppling@users.noreply.github.com>
…files fix(ruby): use rails test for positional file args in rtk rake
…gnostics fix(cargo): preserve test compile diagnostics
…fixture to file Signed-off-by: Adam Powis <apowis@vulncheck.com>
…ibility fix(golangci-lint): add v2 compatibility with runtime version detection
fix(cicd): issue 668 - pre release tag
|
|
Signed-off-by: YoubAmj <11021965+youbamj@users.noreply.github.com>
Signed-off-by: YoubAmj <11021965+youbamj@users.noreply.github.com>
|
Hey We are cleaning up the codebase and improving the project structure for better onboarding. As part of this effort, PR #826 reorganizes No logic changes — only file moves and import path updates. What you need to doRebase your branch on git fetch origin && git rebase origin/developGit detects renames automatically. If you get import conflicts, update the paths: use crate::git; // now: use crate::cmds::git::git;
use crate::tracking; // now: use crate::core::tracking;
use crate::config; // now: use crate::core::config;
use crate::init; // now: use crate::hooks::init;
use crate::gain; // now: use crate::analytics::gain;Need help rebasing? Tag @aeppling |
Summary
npx_command()helper so install-capable fallback paths runnpx -y ...consistently instead of plainnpx ...ccusage,tsc,next, andprismafallback paths to use the shared helper, while leavingnpx --no-installcall sites unchangednpx ccusagebug where interactive approval could block execution and make flows such ascargo test --allappear to hang or time out, and document the fix inCHANGELOG.mdTest plan
cargo fmt --all && cargo clippy --all-targets && cargo testnpx_command()to verify-yis always included./target/debug/rtk cc-economicsreturns without timing out whenccusageis only available vianpx./target/debug/rtk cc-economics --dailyreturns without timing out whenccusageis only available vianpx./target/debug/rtk tsc -- --versionreturns without timing out through thenpxfallback path./target/debug/rtk next -- --helpreturns without timing out through thenpxfallback path./target/debug/rtk prisma generatereturns without timing out through thenpxfallback path and fails fast on missing schema instead of hanging./target/debug/rtk npx prisma --versionreturns without timing out through the passthroughnpxpath./target/release/rtk cc-economicsreturns without timing out whenccusageis only available vianpx./target/release/rtk cc-economics --dailyreturns without timing out whenccusageis only available vianpx./target/release/rtk tsc -- --versionreturns without timing out through thenpxfallback path./target/release/rtk next -- --helpreturns without timing out through thenpxfallback path./target/release/rtk prisma generatereturns without timing out through thenpxfallback path and fails fast on missing schema instead of hanging./target/release/rtk npx prisma --versionreturns without timing out through the passthroughnpxpathCloses #739