Skip to content

fix: track ls savings against baseline output#760

Open
cnaples79 wants to merge 1 commit intortk-ai:masterfrom
cnaples79:master
Open

fix: track ls savings against baseline output#760
cnaples79 wants to merge 1 commit intortk-ai:masterfrom
cnaples79:master

Conversation

@cnaples79
Copy link

Summary

  • measure ls savings against the baseline command output instead of the enriched ls -la
  • record the baseline command string (ls plus user flags/targets) for tracking

Rationale

  • rtk ls should compare compression to what the user would have run (plain ls), not the internal expanded ls -la, to avoid inflated savings

Changes

  • run an additional baseline ls using user flags/paths
  • feed baseline output and command string into tracking instead of the enriched output

Fixes #561

No tests added; behavior unchanged aside from corrected tracking metrics.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@pszymkowiak pszymkowiak added bug Something isn't working effort-small Quelques heures, 1 fichier labels Mar 21, 2026
@pszymkowiak
Copy link
Collaborator

wshm · Automated triage by AI

📊 Automated PR Analysis

🐛 Type bug-fix
🟡 Risk medium

Summary

This PR fixes the ls savings tracking to compare compression against the baseline ls output (what the user would have run) instead of the internally enriched ls -la output. It runs an additional baseline ls command and passes that output and command string to the tracking function, preventing inflated savings metrics.

Review Checklist

  • Tests present
  • Breaking change
  • Docs updated

Linked issues: #561


Analyzed automatically by wshm · This is an automated analysis, not a human review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working effort-small Quelques heures, 1 fichier

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix: ls tracking baseline should compare against ls not ls -la

3 participants