Skip to content

Empty <response/> element.#1

Open
a-iv wants to merge 35 commits intortreffer:masterfrom
a-iv:master
Open

Empty <response/> element.#1
a-iv wants to merge 35 commits intortreffer:masterfrom
a-iv:master

Conversation

@a-iv
Copy link

@a-iv a-iv commented Feb 11, 2011

http://xmpp.org/rfcs/rfc3920.html#rfc.section.6.2, step 3 describes that empty element MUST contains a single equals sign ("=").
But this is not declared for empty .
Some servers doesn't accept such =, for example chrome.pl based on jabberd 2.2.

<challenge xmlns='urn:ietf:params:xml:ns:xmpp-sasl'>cmVhbG09ImNocm9tZS5wbCIsIG5vbmNlPSIwMDAwMDAwMDAwMDAwMDAwMDAwMDAwPT0iLCBxb3A9ImF1dGgiLCBjaGFyc2V0PXV0Zi04LCBhbGdvcml0aG09bWQ1LXNlc3M=</challenge>

<response xmlns="urn:ietf:params:xml:ns:xmpp-sasl">dXNlcm5hbWU9InVzZXIiLHJlYWxtPSJjaHJvbWUucGwiLGNub25jZT0iMDAwMDAwIixuYz0wMDAwMDAwMSxxb3A9YXV0aCxkaWdlc3QtdXJpPSJ4bXBwL2Nocm9tZS5wbCIscmVzcG9uc2U9MDAwMDAwLGNoYXJzZXQ9dXRmLTgsbm9uY2U9IjAwMDAwMD09Ig==</response>

<challenge xmlns='urn:ietf:params:xml:ns:xmpp-sasl'>cnNwYXV0aD0wMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw==</challenge>

<response xmlns="urn:ietf:params:xml:ns:xmpp-sasl">=</response>

<failure xmlns='urn:ietf:params:xml:ns:xmpp-sasl'><incorrect-encoding/></failure>

But:
cmVhbG09ImNocm9tZS5wbCIsIG5vbmNlPSIwMDAwMDAwMDAwMDAwMDAwMDAwMDAwPT0iLCBxb3A9ImF1dGgiLCBjaGFyc2V0PXV0Zi04LCBhbGdvcml0aG09bWQ1LXNlc3M=

<response xmlns="urn:ietf:params:xml:ns:xmpp-sasl">dXNlcm5hbWU9InVzZXIiLHJlYWxtPSJjaHJvbWUucGwiLGNub25jZT0iMDAwMDAwIixuYz0wMDAwMDAwMSxxb3A9YXV0aCxkaWdlc3QtdXJpPSJ4bXBwL2Nocm9tZS5wbCIscmVzcG9uc2U9MDAwMDAwLGNoYXJzZXQ9dXRmLTgsbm9uY2U9IjAwMDAwMD09Ig==</response>

<challenge xmlns='urn:ietf:params:xml:ns:xmpp-sasl'>cnNwYXV0aD0wMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw==</challenge>

<response xmlns="urn:ietf:params:xml:ns:xmpp-sasl" />

<success xmlns='urn:ietf:params:xml:ns:xmpp-sasl'/>

@a-iv
Copy link
Author

a-iv commented Feb 28, 2011

DataForm in FileTransferNegotiator must contains field with TYPE_LIST_SINGLE
(see http://xmpp.org/extensions/xep-0096.html#examples).
For example Gajim reject request with TYPE_LIST_MULTI.

Alexander Ivanov and others added 27 commits March 2, 2011 17:10
Set file size and name for outgoing file transfer from InputStream.
0c06a1b
Revert "initialize ServiceDiscovery on demand"
03237f7 
as it causes problems on disconnect().  Features check the state of the connection with:
        // remove feature from service discovery
        ServiceDiscoveryManager serviceDiscoveryManager = ServiceDiscoveryManager.getInstanceFor(this.connection);

        // check if service discovery is not already disposed by connection shutdown
        if (serviceDiscoveryManager != null) {
            serviceDiscoveryManager.removeFeature(NAMESPACE);
        }

This reverts commit 7ad98dc.
fixing SMACK-329 http://issues.igniterealtime.org/browse/SMACK-329
a480d98
Do disco by component name
f4d8f79
Fix using compression
6a37d9e
Remove chat manager on disconnect
cb68c8e
Fix NullPointerException in disconnect
e3a7f3d
Fix syntax error in last commit
131b812
Catch IllegalStateException in FileTransfer
084a181
fix npe in xhtmlExtensionProvider
44cf742
Pubsub's affiliations fixed.
6c51b12
Incorrect caps calculation fix ("http://jabber.org/protocol/caps" was…
870299d 
… missed).
Fix affiliation provider and packet extension to retrieve all affilia…
4ff5973 
…tions.
merge with 3.2.0
b73cf20
SMACK-338 this should use IBB as fallback protocol if available
781031c 
git-svn-id: http://svn.igniterealtime.org/svn/repos/smack/branches/smack_3_2_0@12409 b35dd754-fafc-0310-a699-88a17e54d16e
Merge branch 'smack-aiv' into 3_2_0
64fdc34
Catch and log exceptions in Smack Listener Processor.
a282398
Pubsub element can be inside the message stanza.
38cc176
Fix NullPointerException in initConnection.
c2b1a2f
Creating a thread and never starting it will cause a memory leak.
b430676
Unregister connections on connectionClosedOnError.
44d445d
Use weak references to connections from managers.
fd2d512
Allow to add connection listener before connection was established.
f1e889a
Don't register connection creation listener from roster.
31c700d
Cache key store.
6d812b4
Merge branch 'changes'
2310a20
Subscription element can be inside http://jabber.org/protocol/pubsub#…
f579c5c 
…event namespace.
ge0rg pushed a commit to ge0rg/smack that referenced this pull request Mar 11, 2012
@Flowdalic
Merge pull request rtreffer#1 from ge0rg/master
672afda 
Fix direct socket connections always trying only one IP address for a given server.
ge0rg pushed a commit to ge0rg/smack that referenced this pull request Feb 18, 2014
@Flowdalic
Merge pull request rtreffer#1 from SnakeDoc/master
207b060 
Add basic markdown README
@4gra 4gra mentioned this pull request May 14, 2014
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@a-iv