Pass logger configuration values through to logger initialization#34
Merged
michaelklishin merged 4 commits intoruby-amqp:mainfrom May 7, 2025
Merged
Pass logger configuration values through to logger initialization#34michaelklishin merged 4 commits intoruby-amqp:mainfrom
michaelklishin merged 4 commits intoruby-amqp:mainfrom
Conversation
| :pid_path => 'sneakers.pid', | ||
| :amqp_heartbeat => 30, | ||
|
|
||
| # Default values from serverengine |
Contributor
Author
|
Passes the test locally after modify a test that looks at the options hash. |
michaelklishin
approved these changes
May 7, 2025
Member
|
@cdhagmann thank you! How soon or how badly do you need a |
Contributor
|
👍 |
Contributor
Author
|
We are able to pass in a logger instance directly for the moment so we are in no rush. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This MR adds three new configuration keys (and their default values) to
Sneakers.configurationthat are passed through to the logger. These keys are:A test had to be updated to expect these keys, but I did not see a place to add testing the affect. Willing to push tests where appropriate.
#33