Skip to content

Handle and re-raise bunny exceptions during work #35

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
michaelklishin merged 1 commit into from
May 17, 2025
Merged

Handle and re-raise bunny exceptions during work #35

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/sneakers/worker.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@ def process_work(delivery_info, metadata, msg, handler)
end
res = block_to_call.call(deserialized_msg, delivery_info, metadata, handler)
end
rescue SignalException, SystemExit
rescue SignalException, SystemExit, Bunny::Exception
# ServerEngine handles these exceptions, so they are not expected to be raised within the worker.
# Nevertheless, they are listed here to ensure that they are not caught by the rescue block below.
raise
Expand Down
8 changes: 8 additions & 0 deletions spec/sneakers/worker_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -446,6 +446,14 @@ def work(msg)
w.do_work(header, nil, "msg", handler)
end

it "should not catch bunny exceptions" do
w = DummyWorker.new(@queue, TestPool.new)
mock(w).work("msg").once{ raise Bunny::Exception }
assert_raises(Bunny::Exception) do
w.do_work(nil, nil, "msg", nil)
end
end

it "should log exceptions from workers" do
handler = Object.new
header = Object.new
Expand Down
Loading