Skip to content

Inherit queue type for retry and error queues#38

Merged
michaelklishin merged 1 commit intoruby-amqp:mainfrom
chris72205:main
Jan 9, 2026
Merged

Inherit queue type for retry and error queues#38
michaelklishin merged 1 commit intoruby-amqp:mainfrom
chris72205:main

Conversation

@chris72205
Copy link
Copy Markdown
Contributor

I can configure a queue as type quorum but this was not reflected in the -error and -retry queues provided by the Maxretry handler. This PR allows setting the queue type based on the x-queue-type argument set in the queue options:

from_queue 'queue-name',
               exchange_options: { durable: true, type: :topic },
               queue_options: { durable: true, arguments: { 'x-queue-type': 'quorum' } },
               routing_key: 'example.key',
               exchange: 'exchange-name'

I also added the ability to specify a specific type for each just in case sharing the type of the queue is not desired.

@michaelklishin
Copy link
Copy Markdown
Member

@chris72205 thank you, you have proactively addressed my key concern: what to do if the user does not want to use quorum queues for everything (a non-replicated classic queue can be a reasonable choice for the "plumbing" queues).

@michaelklishin michaelklishin added this to the 3.3.0 milestone Jan 9, 2026
@michaelklishin michaelklishin merged commit 6187577 into ruby-amqp:main Jan 9, 2026
4 checks passed
@michaelklishin
Copy link
Copy Markdown
Member

I will update the change log to credit @chris72205 later today.

Thank you for contributing!

@chris72205
Copy link
Copy Markdown
Contributor Author

Hey @michaelklishin, any chance this will get released anytime soon? We've been using a forked version with this fix in the mean time but would be nice if we could get back on the main source.

@michaelklishin
Copy link
Copy Markdown
Member

Not before #414 is resolved one way or another, that is, it's being actively worked on.

@chris72205
Copy link
Copy Markdown
Contributor Author

What's #414?

@michaelklishin
Copy link
Copy Markdown
Member

Oops, I thought that was a comment on Hutch 😅 ruby-amqp/hutch#414

I'll produce a new release in a bit, currently trying to ship Bunny 3.0.

@michaelklishin
Copy link
Copy Markdown
Member

@chris72205 3.3.0 is up on rubygems.org. Thanks again for contributing.

@chris72205
Copy link
Copy Markdown
Contributor Author

Ah haha okay, thanks for getting that released!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants