Inherit queue type for retry and error queues#38
Inherit queue type for retry and error queues#38michaelklishin merged 1 commit intoruby-amqp:mainfrom
Conversation
|
@chris72205 thank you, you have proactively addressed my key concern: what to do if the user does not want to use quorum queues for everything (a non-replicated classic queue can be a reasonable choice for the "plumbing" queues). |
|
I will update the change log to credit @chris72205 later today. Thank you for contributing! |
|
Hey @michaelklishin, any chance this will get released anytime soon? We've been using a forked version with this fix in the mean time but would be nice if we could get back on the main source. |
|
Not before #414 is resolved one way or another, that is, it's being actively worked on. |
|
What's #414? |
|
Oops, I thought that was a comment on Hutch 😅 ruby-amqp/hutch#414 I'll produce a new release in a bit, currently trying to ship Bunny 3.0. |
|
@chris72205 |
|
Ah haha okay, thanks for getting that released! |
I can configure a queue as type
quorumbut this was not reflected in the-errorand-retryqueues provided by theMaxretryhandler. This PR allows setting the queue type based on thex-queue-typeargument set in the queue options:I also added the ability to specify a specific type for each just in case sharing the type of the queue is not desired.