Faq position migration #646
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maebeale
approved these changes
Jan 8, 2026
Collaborator
maebeale
left a comment
maebeale
left a comment
There was a problem hiding this comment.
So glad to have this modernized and resolved!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the goal of this PR and why is this important?
Faq's have been migrated to production and healed. This changes the column to
:positionwhich aligns with the positioning gem naming convention. Using the default column name will give the ability to add scoped positions in the future as well as be more clear to future devs when handling position columns handled by the gem.How did you approach the change?
Ran
Faq.heal_ordering_column!in production to fix any null or duplicate positions and added a migration to change the column name to the Positioning gem default.Add null constraint.
Anything else to add?
Create a list of all other models that should be updated to follow the same naming convention.