Update turning circles plugin

[anmcgrath]

Fix issues with plugin not working when started with player already on their boat by checking varbits every frame.

[runelite-github-app]

turning-circles: 47b45c2fe1cf44394b6d910f427fe542d464f68a..f4bd73543511ada38f1e3cfea032b4b880d36c5c

[runelite-github-app]

Internal use only: Reviewer details Maintainer details

[iProdigy]

checking varbits every frame

Are you sure this is necessary?

could you first try making the boolean volatile and/or checking every ClientTick instead

[anmcgrath]

Hi @iProdigy I went back and revisited - now only setting on startup and then when they change.

I'm new to plugin development, is checking varbits each frame quite expensive? Appreciate your help.

[iProdigy]

Hi @iProdigy I went back and revisited - now only setting on startup and then when they change.

Thank you

I'm new to plugin development, is checking varbits each frame quite expensive? Appreciate your help.

It's cheap (constant-time lookup from the getVarps array), but the first step (obtaining VarbitComposition) should be done from the client thread (and then the array lookup & bit shifting is fine to do per frame)... though the VarbitChanged approach is cleaner
https://github.com/runelite/wiki/blob/master/VarPlayers%2C-VarBits%2C-and-VarClients.md#how-varbits-work-internally