Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changing the base image to
ENTRYPOINT ["/start.sh"]hard-codes/start.shas the executable for all child images. In Docker, a childCMDis then passed as arguments to that entrypoint, so a downstream image likeFROM runpod/base ... CMD ["python","app.py"]will execute/start.sh python app.pyinstead of startingpythondirectly. Sincecontainer-template/start.shdoes not forward"$@"and always ends insleep infinity, those child-image commands will never run, which is a backward-incompatible regression for users extending this base image.Useful? React with 👍 / 👎.