Skip to content
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion official-templates/base/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -118,4 +118,4 @@ COPY --from=logo runpod.txt /etc/runpod.txt
RUN echo 'cat /etc/runpod.txt' >> /root/.bashrc
RUN echo 'echo -e "\nFor detailed documentation and guides, please visit:\n\033[1;34mhttps://docs.runpod.io/\033[0m and \033[1;34mhttps://blog.runpod.io/\033[0m\n\n"' >> /root/.bashrc

CMD ["/start.sh"]
ENTRYPOINT ["/start.sh"]
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Keep CMD overrides working in derived images

Changing the base image to ENTRYPOINT ["/start.sh"] hard-codes /start.sh as the executable for all child images. In Docker, a child CMD is then passed as arguments to that entrypoint, so a downstream image like FROM runpod/base ... CMD ["python","app.py"] will execute /start.sh python app.py instead of starting python directly. Since container-template/start.sh does not forward "$@" and always ends in sleep infinity, those child-image commands will never run, which is a backward-incompatible regression for users extending this base image.

Useful? React with 👍 / 👎.

Loading