-
Notifications
You must be signed in to change notification settings - Fork 14k
Error if an autodiff user does not set lto=fat #148855
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
This comment has been minimized.
This comment has been minimized.
|
r? @bjorn3 |
|
Failed to set assignee to
|
b097bb6 to
370542e
Compare
|
This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
370542e to
9b84ba2
Compare
This comment has been minimized.
This comment has been minimized.
9b84ba2 to
b07b6fa
Compare
This comment has been minimized.
This comment has been minimized.
b07b6fa to
1f700b6
Compare
This comment has been minimized.
This comment has been minimized.
1f700b6 to
c8bae8c
Compare
Based on your feedback, I started to provide a nice error message for a lack of
lto=fat, instead of us forcing it.In a next step, we should replace
RUSTFLAGS="-Zautodiff=Enable"with another Cargo.toml setting, as discussed here: #147487 (comment)As another improvement, we should also figure out why rlib builds do not properly obey the fat=lto setting.
@bjorn3