Skip to content

Conversation

@ZuseZ4
Copy link
Member

@ZuseZ4 ZuseZ4 commented Nov 12, 2025

Based on your feedback, I started to provide a nice error message for a lack of lto=fat, instead of us forcing it.

In a next step, we should replace RUSTFLAGS="-Zautodiff=Enable" with another Cargo.toml setting, as discussed here: #147487 (comment)

As another improvement, we should also figure out why rlib builds do not properly obey the fat=lto setting.

@bjorn3

@rustbot
Copy link
Collaborator

rustbot commented Nov 12, 2025

r? @madsmtm

rustbot has assigned @madsmtm.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Nov 12, 2025
@rustbot

This comment has been minimized.

@ZuseZ4 ZuseZ4 changed the title provide an error if an autodiff user does not set in their Cargo.toml provide an error if an autodiff user does not enable lto=fat in their Cargo.toml Nov 12, 2025
@ZuseZ4 ZuseZ4 changed the title provide an error if an autodiff user does not enable lto=fat in their Cargo.toml Error if an autodiff user does not set lto=fat Nov 12, 2025
@ZuseZ4
Copy link
Member Author

ZuseZ4 commented Nov 12, 2025

r? @bjorn3

@rustbot
Copy link
Collaborator

rustbot commented Nov 12, 2025

Failed to set assignee to bjorn: invalid assignee

Note: Only org members with at least the repository "read" role, users with write permissions, or people who have commented on the PR may be assigned.

@rustbot rustbot assigned bjorn3 and unassigned madsmtm Nov 12, 2025
@ZuseZ4 ZuseZ4 force-pushed the autodiff-lto-error branch from b097bb6 to 370542e Compare November 12, 2025 03:50
@rustbot
Copy link
Collaborator

rustbot commented Nov 12, 2025

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

@ZuseZ4 ZuseZ4 force-pushed the autodiff-lto-error branch from 370542e to 9b84ba2 Compare November 12, 2025 03:53
@rust-log-analyzer

This comment has been minimized.

@ZuseZ4 ZuseZ4 force-pushed the autodiff-lto-error branch from 9b84ba2 to b07b6fa Compare November 12, 2025 04:01
@rust-log-analyzer

This comment has been minimized.

@ZuseZ4 ZuseZ4 force-pushed the autodiff-lto-error branch from b07b6fa to 1f700b6 Compare November 12, 2025 04:12
@rust-log-analyzer

This comment has been minimized.

@ZuseZ4 ZuseZ4 force-pushed the autodiff-lto-error branch from 1f700b6 to c8bae8c Compare November 12, 2025 04:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants