Skip to content

Conversation

@skbeh
Copy link

@skbeh skbeh commented Aug 21, 2025

Use a 'with' statement to handle socket creation and cleanup.

This ensures that sockets are always closed properly, even when exceptions occur, preventing potential resource leaks.

Use a 'with' statement to handle socket creation and cleanup.

This ensures that sockets are always closed properly, even when exceptions occur, preventing potential resource leaks.
@codecov
Copy link

codecov bot commented Aug 21, 2025

Codecov Report

❌ Patch coverage is 0% with 65 lines in your changes missing coverage. Please review.
✅ Project coverage is 82.27%. Comparing base (c5cc0f2) to head (ce02ea2).

Files with missing lines Patch % Lines
miio/miioprotocol.py 0.00% 58 Missing and 2 partials ⚠️
miio/push_server/server.py 0.00% 5 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2039   +/-   ##
=======================================
  Coverage   82.26%   82.27%           
=======================================
  Files         197      197           
  Lines       19145    19144    -1     
  Branches     1052     1052           
=======================================
  Hits        15750    15750           
+ Misses       3218     3217    -1     
  Partials      177      177           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant