Skip to content

No return from delete() according to INode::delete() #1610

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ChristophWurst merged 1 commit into from
Dec 12, 2025
Merged

No return from delete() according to INode::delete() #1610

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions lib/DAV/FSExt/Directory.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,8 +143,6 @@ public function getChildren()

/**
* Deletes all files in this directory, and then itself.
*
* @return bool
*/
public function delete()
{
Expand All @@ -155,8 +153,6 @@ public function delete()

// Removing the directory itself
rmdir($this->path);

return true;
}

/**
Expand Down
4 changes: 1 addition & 3 deletions lib/DAV/FSExt/File.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,12 +102,10 @@ public function get()

/**
* Delete the current file.
*
* @return bool
*/
public function delete()
{
return unlink($this->path);
unlink($this->path);
}

/**
Expand Down