Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces a new user-configurable widget transparency setting, allowing users to adjust the transparency of the AirSync widget background via the app's settings. It also improves user feedback for connection issues by displaying more informative toast messages. The main changes are grouped below:
Widget Transparency Feature:
widgetTransparencyfloat preference toDataStoreManager, along with getter and setter methods to persist and retrieve the value. [1] [2]AirSyncRepositoryandAirSyncRepositoryImpl) to expose methods for setting and getting widget transparency. [1] [2]UiStatedata class andAirSyncViewModelto track and update widget transparency, including observing changes and syncing them to the widget. [1] [2] [3]ConfigSliderItemcomposable for adjustable slider controls, and integrated it into the Settings screen under a new "Widget" section for transparency adjustment. [1] [2]AirSyncWidgetProviderto apply the user-selected transparency to the widget background using the stored alpha value.User Feedback Improvements:
WebSocketUtilto show more descriptive toast messages to users on disconnection and connection failures, helping users better understand connection issues. [1] [2]These changes collectively improve the widget's customization options and the overall user experience regarding connection feedback.