Conversation
github-project-automation
bot
moved this from Backlog
to Done
in AirSync Features and Bugs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces two major features to the project: a new custom menu bar (menubar) integration for the macOS app and the addition of Sentry crash reporting. The menu bar now includes a dynamic status icon, popover window, and device status text, while Sentry integration enables crash reporting that can be toggled by the user. Several supporting changes were made to AppState and project files to support these features.
Menu Bar Integration:
MenuBarManagerclass to handle the app's menu bar status item, including dynamic icon, text, and a popover window (airsync-mac/Core/MenuBarManager.swift).AppDelegateto initializeMenuBarManageron launch (airsync-mac/Core/AppDelegate.swift). [1] [2]AppStatewith new properties to control menubar behavior (isMenubarWindowOpen) and support for dynamic text (airsync-mac/Core/AppState.swift).MenuBarLabelView(airsync-mac/Screens/MenubarView/MenuBarLabelView.swift).Sentry Crash Reporting Integration:
AirSync.xcodeproj/project.pbxproj,AirSync.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved). [1] [2] [3] [4] [5] [6] [7] [8]SentryInitializerstruct to handle Sentry SDK startup, respecting the user's crash reporting preference (airsync-mac/Core/SentryInitializer.swift).AppDelegateto initialize Sentry at launch (airsync-mac/Core/AppDelegate.swift).isCrashReportingEnabledproperty toAppStateand persisted it in user defaults (airsync-mac/Core/AppState.swift). [1] [2]UI/UX Improvements:
DropTargetOverlayvisual style for a more modern appearance (airsync-mac/Components/Custom/DropTargetModifier.swift).airsync-mac/Screens/MenubarView/MenubarView.swift).These changes collectively modernize the app's menu bar experience and introduce robust crash reporting capabilities.