Develop - Wired ADB, Connection pill, Connection pop-up, Recent apps and a lot of fixes#196
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces several enhancements and new features to the AirSync macOS app, focusing on improved ADB connection flexibility, recent app tracking, and UI improvements for connection status. The most significant changes include support for wired ADB connections, persistent tracking of recently used Android apps, and a new interactive connection status pill in the UI.
ADB Connection Enhancements:
wiredAdbEnabledsetting, detection logic, and UI indicators for connection mode (wired or wireless). The app now attempts a wired ADB connection first if enabled, falling back to wireless if necessary. (airsync-mac/Core/AppState.swiftF248f47e,airsync-mac/Core/WebSocket/WebSocketServer+Handlers.swiftF7a18b38,airsync-mac/Localization/en.jsonF2d79eb0,AirSync.xcodeproj/project.pbxprojF9271129)airsync-mac/Core/AppState.swiftF248f47e)Recent Apps Feature:
airsync-mac/Core/AppState.swiftF248f47e,airsync-mac/Screens/HomeScreen/AppsView/AppGridView.swiftF9f26bd1)UI Improvements:
ConnectionStatusPillSwiftUI component that visually shows connection status, ADB mode (wired/wireless), and provides a popover with detailed connection info and quick actions (connect/disconnect ADB/device). (airsync-mac/Screens/HomeScreen/PhoneView/ConnectionStatusPill.swiftFd861077)airsync-mac/Screens/HomeScreen/PhoneView/ConnectionStateView.swiftFddc4156)Other Improvements and Fixes:
MacInfoSyncManagerare dispatched on the main thread for UI consistency. (airsync-mac/Core/Util/MacInfo/MacInfoSyncManager.swiftF9cda6e5)airsync-mac/Core/Util/Gumroad.swiftFde57b80)Project Metadata Updates:
AirSync.xcodeproj/project.pbxprojF9271129)These changes collectively improve the user experience by making ADB connections more robust and transparent, providing users with quick access to their most-used apps, and giving clear visual feedback about device and connection status.