Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces several significant improvements to the AirSync macOS project, focusing on enhancing Quick Share functionality, improving the drag-and-drop user experience, and adding new dependencies to support cryptographic and protocol features. The most notable changes include a major refactor of the drop target logic for file and text sharing, the addition of a new animated radar view for device selection, and the integration of multiple Swift packages for cryptography and protobuf support.
Quick Share and Drag-and-Drop Improvements:
DropTargetModifierand related logic to use a customDropDelegate(QuickShareDropDelegate). This enables more robust handling of drag-and-drop events, supports both file and text drops, provides dynamic overlay labeling based on modifier keys and device state, and improves user feedback during the drag operation. [1] [2]Quick Share Workflow Integration:
UI Enhancements:
RadarViewSwiftUI component that displays discovered devices as animated nodes around a central "self" node, providing an engaging and intuitive interface for selecting target devices during Quick Share.Dependency Management:
BigInt,ASN1,SwiftECC, andswift-protobuf, updating both the Xcode project andPackage.resolvedto support cryptographic operations and protobuf serialization. [1] [2] [3] [4] [5] [6] [7] [8] [9]General Codebase Maintenance:
AppState.swift. [1] [2]Most important changes:
Quick Share and Drag-and-Drop Improvements
DropTargetModifierto use a customDropDelegate, enabling improved drag-and-drop handling for both files and text, dynamic overlay labels, and better user feedback. [1] [2]Quick Share Workflow Integration
UI Enhancements
RadarViewcomponent for device selection during Quick Share, improving the device discovery and selection interface.Dependency Management
BigInt,ASN1,SwiftECC,swift-protobuf) for cryptographic and protobuf support, updating both the Xcode project and SwiftPM configuration files. [1] [2] [3] [4] [5] [6] [7] [8] [9]General Codebase Maintenance
AppState.swift. [1] [2]