Conversation
Nearby - QuickShare support
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces several major improvements to the AirSync macOS project, primarily focused on enhancing file and text sharing via a new Quick Share feature. It adds new package dependencies, refactors drag-and-drop handling for better user experience, and introduces a visually engaging device selection interface. Additionally, it updates the app's initialization and file handling logic to integrate the new Quick Share workflow.
Key changes:
Quick Share Feature Integration
DropTargetModifier.swiftto use a newQuickShareDropDelegate, providing improved handling for both file and text drops, dynamic overlay labels, and support for modifier key detection. The new logic initiates device discovery and launches a transfer UI when files are dropped, or sends text directly if appropriate. [1] [2]RadarViewcomponent to visually display nearby devices in a radar-like interface, allowing users to select a target device for sharing.Dependency Management
BigInt,ASN1,SwiftECC, andswift-protobufto the Xcode project configuration and lockfile, enabling cryptographic and protocol support needed for Quick Share. [1] [2] [3] [4] [5] [6] [7] [8] [9]App Initialization and File Handling
AppDelegateto initializeQuickShareManagerat launch, and refactored file opening and Services menu actions to use the new Quick Share workflow instead of direct WebSocket file sending. This ensures a consistent and modern sharing experience. [1] [2]Miscellaneous Improvements
AirSync-Bridging-Header.h) for Objective-C/Swift interoperability, currently importing a notification center utility.internal import Combinestatement inAppState.swiftto standardimport Combine.