Develop - New app icon and branding, Device mappign updates, QS auto accept support for Android, Translations#202
Merged
Conversation
New Crowdin updates
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces several updates across the project, including improvements to Quick Share functionality, updates to Mac device mappings, and a major version bump. The most significant changes are the addition of a new app icon, enhanced Quick Share triggers for better device discovery and transfer, and expanded support for new Mac models.
Quick Share feature improvements:
QuickShareManagernow sends a WebSocket trigger (sendQuickShareTrigger) when starting discovery or initiating a transfer to the currently connected device, ensuring Android devices are prompted to enter Quick Share mode automatically. (airsync-mac/Core/QuickShare/QuickShareManager.swift[1] [2];airsync-mac/Core/WebSocket/WebSocketServer+Outgoing.swift[3]transferURLsand starting discovery has been standardized in both the drop delegate and app delegate, ensuring URLs are set before discovery begins. (airsync-mac/Components/Custom/DropTargetModifier.swift[1];airsync-mac/Core/AppDelegate.swift[2]NearbyConnectionfor easier debugging of connection states. (airsync-mac/Core/QuickShare/NearbyConnection.swift[1] [2]Project configuration and app icon:
AppIcon.iconasset and updated the Xcode project to use it as the main app icon, replacingAppIcon-uni.icon. (AirSync.xcodeproj/project.pbxproj[1] [2] [3] [4] [5] [6] [7] [8] [9] [10];AppIcon.icon/icon.json[11]Device support and mappings:
MacDeviceMappings.jsonto include new and upcoming MacBook, MacBook Pro, MacBook Neo, Mac mini, iMac, Mac Studio, and Mac Pro models, and improved the accuracy of existing model names. (airsync-mac/Constants/MacDeviceMappings.jsonairsync-mac/Constants/MacDeviceMappings.jsonL3-R102)Versioning and build settings:
3.0.0and the project version to25to reflect a major release. (AirSync.xcodeproj/project.pbxproj[1] [2] [3] [4] [5] [6]WebSocket improvements:
airsync-mac/Core/WebSocket/WebSocketServer.swiftairsync-mac/Core/WebSocket/WebSocketServer.swiftR209-R212)