mrib.c: don't use cpu_to_be32 outside of function#2
Open
cotequeiroz wants to merge 1 commit intosbyx:masterfrom
Open
mrib.c: don't use cpu_to_be32 outside of function#2cotequeiroz wants to merge 1 commit intosbyx:masterfrom
cotequeiroz wants to merge 1 commit intosbyx:masterfrom
Conversation
cpu_to_be32 is not a constant, so it can't be used outside of a function. Signed-off-by: Eneas U de Queiroz <cote2004-github@yahoo.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cpu_to_be32is not a constant, so it can't be used outside of a function.Compilation fails on little-endian machines with:
Linux kernel defines
__constant_cpu_to_be32somewhere, but including its headers was messy. It is used only once, so it is simpler to just spell out the constant.Signed-off-by: Eneas U de Queiroz cote2004-github@yahoo.com